feat(rust): add env locked metadata functions
#16719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
enhancement
ritchie46
reviewed
Jun 5, 2024
|
And CI is failing. You have a lint error. |
coastalwhite
force-pushed
the
metadata-env-lock
branch
from
6bb79bf
to
c9e45ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16719 +/- ##
==========================================
- Coverage 81.49% 81.38% -0.11%
==========================================
Files 1416 1415 -1
Lines 186880 186429 -451
Branches 3023 2776 -247
==========================================
- Hits 152289 151729 -560
- Misses 34059 34180 +121
+ Partials 532 520 -12 ☔ View full report in Codecov by Sentry. |
This prepares for further use of metadata. This locks several functionalities of the metadata behind the `POLARS_METADATA_FLAGS` environment variable when compiling on `debug`-mode. This is either `0` to disable all metadata, or `extensive` and `log` possibility delimited by `,`. This enables further experimental features like `extensive` use of the metadata and `log`ging of every time the metadata is used.
coastalwhite
force-pushed
the
metadata-env-lock
branch
from
c9e45ec
to
df86903
Compare
CodSpeed Performance ReportMerging #16719 will improve performances by 15.86%Comparing Summary
Benchmarks breakdown
|
ritchie46
reviewed
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for further use of the metadata. This locks several functionalities of the metadata behind the
POLARS_METADATA_FLAGSenvironment variable when compiling ondebug-mode. This is either0to disable all metadata, orextensiveandlogpossibility delimited by,. This enables further experimental features likeextensiveuse of the metadata andlogging of every time the metadata is used.